Support Go Modules #144
Merged
Support Go Modules #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
containerd/project#25 has been merged! So we need to remove |
Contributor
Author
|
@kzys I didn't think about this before, but this repo is tested against multiple versions of Go. While this is great, sadly the Go team can't stop breaking vendoring and changes to the go.mod file in every version of Go, so Go 1.11, 1.12, and 1.13 may all result in different EDIT: for now I've tried creating a separate validation stage in CI with a fixed version of Go. Hopefully that works. |
Member
|
Oh, I thought it was still there. Thanks. Regarding the remaining failures, you would need to have |
Signed-off-by: Sam Whited <sam@samwhited.com>
Contributor
Author
|
Ah yes, I forgot that Go 1.11 didn't have the behavior where it does different things depending on whether it finds a |
Contributor
Author
|
Fixed conflict. Gentle ping. |
AkihiroSuda
approved these changes
Dec 14, 2019
thaJeztah
added a commit
to thaJeztah/buildkit
that referenced
this pull request
Jan 13, 2020
…ce1fc84c4c4 full diff: containerd/continuity@75bee3e...26c1120 - containerd/continuity#109 Add OpenBSD support for fs subpackage - containerd/continuity#144 Support Go Modules - containerd/continuity#147 xattr lost when copying directory - containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/buildkit
that referenced
this pull request
Jan 13, 2020
…ce1fc84c4c4 full diff: containerd/continuity@75bee3e...26c1120 - containerd/continuity#109 Add OpenBSD support for fs subpackage - containerd/continuity#144 Support Go Modules - containerd/continuity#147 xattr lost when copying directory - containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 13, 2020
…ce1fc84c4c4 full diff: containerd/continuity@f2a389a...26c1120 - containerd/continuity#109 Add OpenBSD support for fs subpackage - containerd/continuity#141 Add src string to copyDirectory error message - containerd/continuity#143 fstest: have CreateSocket actually create a socket - containerd/continuity#144 Support Go Modules - containerd/continuity#147 xattr lost when copying directory - containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jan 13, 2020
…ce1fc84c4c4 full diff: containerd/continuity@f2a389a...26c1120 - containerd/continuity#109 Add OpenBSD support for fs subpackage - containerd/continuity#141 Add src string to copyDirectory error message - containerd/continuity#143 fstest: have CreateSocket actually create a socket - containerd/continuity#144 Support Go Modules - containerd/continuity#147 xattr lost when copying directory - containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 67a0695e8b355c7a1c3382b7165f97a2bafc5f9b Component: engine
thaJeztah
added a commit
to thaJeztah/buildkit
that referenced
this pull request
Jan 16, 2020
…ce1fc84c4c4 full diff: containerd/continuity@75bee3e...26c1120 - containerd/continuity#109 Add OpenBSD support for fs subpackage - containerd/continuity#144 Support Go Modules - containerd/continuity#147 xattr lost when copying directory - containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit e0ac634) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Feb 12, 2020
…ce1fc84c4c4 full diff: containerd/continuity@f2a389a...26c1120 full diff: containerd/continuity@f2a389a...26c1120 - containerd/continuity#109 Add OpenBSD support for fs subpackage - containerd/continuity#141 Add src string to copyDirectory error message - containerd/continuity#143 fstest: have CreateSocket actually create a socket - containerd/continuity#144 Support Go Modules - containerd/continuity#147 xattr lost when copying directory - containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Feb 12, 2020
…ce1fc84c4c4 full diff: containerd/continuity@f2a389a...26c1120 full diff: containerd/continuity@f2a389a...26c1120 - containerd/continuity#109 Add OpenBSD support for fs subpackage - containerd/continuity#141 Add src string to copyDirectory error message - containerd/continuity#143 fstest: have CreateSocket actually create a socket - containerd/continuity#144 Support Go Modules - containerd/continuity#147 xattr lost when copying directory - containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Feb 13, 2020
…ce1fc84c4c4 full diff: containerd/continuity@f2a389a...26c1120 full diff: containerd/continuity@f2a389a...26c1120 - containerd/continuity#109 Add OpenBSD support for fs subpackage - containerd/continuity#141 Add src string to copyDirectory error message - containerd/continuity#143 fstest: have CreateSocket actually create a socket - containerd/continuity#144 Support Go Modules - containerd/continuity#147 xattr lost when copying directory - containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 507e6b61cf82059ce412ccdb531b0e9402d2d2a8 Component: cli
eiffel-fl
pushed a commit
to eiffel-fl/cli
that referenced
this pull request
Jul 28, 2020
…ce1fc84c4c4 full diff: containerd/continuity@f2a389a...26c1120 full diff: containerd/continuity@f2a389a...26c1120 - containerd/continuity#109 Add OpenBSD support for fs subpackage - containerd/continuity#141 Add src string to copyDirectory error message - containerd/continuity#143 fstest: have CreateSocket actually create a socket - containerd/continuity#144 Support Go Modules - containerd/continuity#147 xattr lost when copying directory - containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please also consider adding a semver compatible tag such as
v0.0.1, thank you for your consideration.EDIT apologies for the re-vendor, I can remove that change but thought it would be useful to go ahead and have the vendor tree created by
go mod vendor. In general I would say it's best not to vendor in libraries and to rely on the binaries that depend on this library to vendor if they need it, but not knowing much about this project I wanted to keep the changes small (scope wise, obviously it's a lot of files still).EDIT: CI will depend on containerd/project#25