Skip to content

[Refactor] Refactor the kill command flagging process#1836

Merged
AkihiroSuda merged 1 commit into
containerd:mainfrom
Laitr0n:refactor_kill
Jan 16, 2023
Merged

[Refactor] Refactor the kill command flagging process#1836
AkihiroSuda merged 1 commit into
containerd:mainfrom
Laitr0n:refactor_kill

Conversation

@Laitr0n
Copy link
Copy Markdown
Contributor

@Laitr0n Laitr0n commented Jan 12, 2023 •
edited
Loading

Part of #1680

  • Create a file in pkg/api/types/${cmd}_types.go, and define the CommandOption for this command
  • Create some file in pkg/cmd/${cmd}, and move the command entry point in real into this package

Signed-off-by: Laitron meetlq@outlook.com

@Laitr0n Laitr0n changed the title [Refactor] Refactor the kill command flagging process. [Refactor] Refactor the kill command flagging process Jan 12, 2023
@Laitr0n Laitr0n marked this pull request as ready for review January 12, 2023 23:59
AkihiroSuda
AkihiroSuda reviewed Jan 13, 2023
View reviewed changes
Comment thread pkg/cmd/kill/kill.go
@Laitr0n Laitr0n requested a review from AkihiroSuda January 13, 2023 12:44
@Laitr0n
Copy link
Copy Markdown
Contributor Author

Laitr0n commented Jan 15, 2023

@AkihiroSuda @djdongjin PTAL
It is possible that running a restart again may resolve my failed check actions.

djdongjin
djdongjin reviewed Jan 15, 2023
View reviewed changes
Comment thread pkg/cmd/container/kill.go Outdated
Comment thread pkg/cmd/container/kill.go Outdated
Comment thread pkg/cmd/container/kill.go Outdated
@Laitr0n
[Refactor] Refactor the kill command flagging process.
e49e9be 
Signed-off-by: Laitron <meetlq@outlook.com>
@Laitr0n Laitr0n requested review from AkihiroSuda and djdongjin and removed request for AkihiroSuda and djdongjin January 16, 2023 02:07
djdongjin
djdongjin reviewed Jan 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Laitr0n Laitr0n requested a review from AkihiroSuda January 16, 2023 12:52
AkihiroSuda
AkihiroSuda approved these changes Jan 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 0b051a5 into containerd:main Jan 16, 2023
@Laitr0n Laitr0n deleted the refactor_kill branch January 16, 2023 16:06
@AkihiroSuda AkihiroSuda added this to the v1.2.0 milestone Jan 17, 2023
@davidhsingyuchen davidhsingyuchen mentioned this pull request Jan 18, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djdongjin djdongjin djdongjin left review comments

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Laitr0n @AkihiroSuda @djdongjin