refactor: image tag flagging process#1869
Merged
Merged
Conversation
Signed-off-by: Hsing-Yu (David) Chen <davidhsingyuchen@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1680
pkg/api/types/${cmd}_types.go, and define the CommandOption for this commandpkg/cmd/${cmd}, and move the command entry point in real into this packageNotes:
cmd/nerdctl/tag.gotocmd/nerdctl/image_tag.gobecause it's the canonical name. Please let me know if it should be done in another PR instead.ImageTagCommandOptions(i.e.,SourceandTarget) come from the description of the command.cmd/nerdctl/images.gois parsing the image references, but that should be because the filters need to be created based on those references as it makes sense to letimage.List()only accept filters as an uniformed interface. As a result, I left the image reference parsing code inpkg/cmd/image/tag.goinstead.Signed-off-by: Hsing-Yu (David) Chen davidhsingyuchen@gmail.com