Skip to content

refactor: image tag flagging process#1869

Merged
AkihiroSuda merged 1 commit into
containerd:mainfrom
davidhsingyuchen:refactor-tag-flags
Jan 19, 2023
Merged

refactor: image tag flagging process#1869
AkihiroSuda merged 1 commit into
containerd:mainfrom
davidhsingyuchen:refactor-tag-flags

Conversation

@davidhsingyuchen
Copy link
Copy Markdown
Contributor

@davidhsingyuchen davidhsingyuchen commented Jan 18, 2023

Part of #1680

  • Create a file in pkg/api/types/${cmd}_types.go, and define the CommandOption for this command
  • Create some file in pkg/cmd/${cmd}, and move the command entry point in real into this package

Notes:

Signed-off-by: Hsing-Yu (David) Chen davidhsingyuchen@gmail.com

Signed-off-by: Hsing-Yu (David) Chen <davidhsingyuchen@gmail.com>
@davidhsingyuchen davidhsingyuchen marked this pull request as ready for review January 18, 2023 02:51
@AkihiroSuda AkihiroSuda added this to the v1.2.0 milestone Jan 19, 2023
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 6f35946 into containerd:main Jan 19, 2023
@davidhsingyuchen davidhsingyuchen deleted the refactor-tag-flags branch January 19, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants