Skip to content

[Refactor] refactor container restart flagging process#1899

Merged
AkihiroSuda merged 1 commit into
containerd:mainfrom
suyanhanx:refactor-container-restart-command
Jan 26, 2023
Merged

[Refactor] refactor container restart flagging process#1899
AkihiroSuda merged 1 commit into
containerd:mainfrom
suyanhanx:refactor-container-restart-command

Conversation

@suyanhanx
Copy link
Copy Markdown
Contributor

@suyanhanx suyanhanx commented Jan 21, 2023

part of #1680

Checklist:

  • Create a file in pkg/api/types/${cmd}_types.go, and define the CommandOption for this command
  • Create some file in pkg/cmd/${cmd}, and move the command entry point in real into this package

waiting for the finish of

Signed-off-by: suyanhanx suyanhanx@gmail.com

@Zheaoli Zheaoli added this to the v1.x milestone Jan 23, 2023
@suyanhanx suyanhanx force-pushed the refactor-container-restart-command branch 3 times, most recently from 7c3640a to dfea7d0 Compare January 24, 2023 11:43
@suyanhanx suyanhanx marked this pull request as ready for review January 24, 2023 11:46
Comment thread cmd/nerdctl/container_restart.go Outdated
Comment thread cmd/nerdctl/container_restart.go
@suyanhanx suyanhanx force-pushed the refactor-container-restart-command branch 2 times, most recently from 60d6e32 to 5e1c781 Compare January 25, 2023 00:28
Comment thread pkg/cmd/container/restart.go Outdated
@suyanhanx suyanhanx force-pushed the refactor-container-restart-command branch from 5e1c781 to 7c25cfa Compare January 25, 2023 02:44
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx force-pushed the refactor-container-restart-command branch from 7c25cfa to efe04d9 Compare January 25, 2023 10:37
Copy link
Copy Markdown
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda modified the milestones: v1.x, v1.2.0 Jan 26, 2023
@AkihiroSuda AkihiroSuda merged commit ccb2f94 into containerd:main Jan 26, 2023
@suyanhanx suyanhanx deleted the refactor-container-restart-command branch January 26, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants