Skip to content

[Refactor] Refactor the container start command flagging process#1864

Merged
AkihiroSuda merged 1 commit into
containerd:mainfrom
Laitr0n:refactor_container_start
Jan 24, 2023
Merged

[Refactor] Refactor the container start command flagging process#1864
AkihiroSuda merged 1 commit into
containerd:mainfrom
Laitr0n:refactor_container_start

Conversation

@Laitr0n
Copy link
Copy Markdown
Contributor

@Laitr0n Laitr0n commented Jan 17, 2023

Part of #1680

Checklist:

  • Move startContainer from cmd to pkg/containerutil
  • Create a file in pkg/api/types/${cmd}_types.go, and define the CommandOption for this command
  • Create some file in pkg/cmd/${cmd}, and move the command entry point in real into this package

Signed-off-by: Laitron meetlq@outlook.com

@Laitr0n Laitr0n changed the title [Refactor] Refactor the container start command flagging process #1756 [Refactor] Refactor the container start command flagging process Jan 17, 2023
@Laitr0n Laitr0n force-pushed the refactor_container_start branch 4 times, most recently from ef56212 to 992fd2f Compare January 17, 2023 15:02
@Laitr0n
Copy link
Copy Markdown
Contributor Author

Laitr0n commented Jan 17, 2023

I have made an enormous change to refactor the container start command flagging process, but I break it down into 8 smaller commits which list in the checklist at the top comment.

@Laitr0n Laitr0n marked this pull request as ready for review January 17, 2023 15:51
@Laitr0n
Copy link
Copy Markdown
Contributor Author

Laitr0n commented Jan 19, 2023

@AkihiroSuda @djdongjin @Zheaoli PTAL
If there are any problems,please let me know.<3

@Laitr0n Laitr0n closed this Jan 19, 2023
@Laitr0n Laitr0n reopened this Jan 20, 2023
@Laitr0n Laitr0n changed the title [Refactor] Refactor the container start command flagging process [WIP][Refactor] Refactor the container start command flagging process Jan 20, 2023
@Laitr0n Laitr0n marked this pull request as draft January 20, 2023 16:01
@Laitr0n Laitr0n force-pushed the refactor_container_start branch 4 times, most recently from 462c95d to f48deac Compare January 23, 2023 12:29
Signed-off-by: Laitron <meetlq@outlook.com>
@Laitr0n Laitr0n force-pushed the refactor_container_start branch from f48deac to 801320a Compare January 23, 2023 14:33
@Laitr0n Laitr0n changed the title [WIP][Refactor] Refactor the container start command flagging process [Refactor] Refactor the container start command flagging process Jan 23, 2023
@Laitr0n Laitr0n marked this pull request as ready for review January 23, 2023 15:16
@AkihiroSuda AkihiroSuda added this to the v1.2.0 milestone Jan 24, 2023
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 33804b3 into containerd:main Jan 24, 2023
@Laitr0n Laitr0n deleted the refactor_container_start branch January 24, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants