Skip to content

[Refactor] Move reconfigNetContainer and reconfigPIDContainer from cm…#1902

Merged
AkihiroSuda merged 1 commit into
containerd:mainfrom
Laitr0n:refactor_reconfig_container
Jan 23, 2023
Merged

[Refactor] Move reconfigNetContainer and reconfigPIDContainer from cm…#1902
AkihiroSuda merged 1 commit into
containerd:mainfrom
Laitr0n:refactor_reconfig_container

Conversation

@Laitr0n
Copy link
Copy Markdown
Contributor

@Laitr0n Laitr0n commented Jan 23, 2023

Splitting pr #1864
Prepare for refactor the container start command.

Signed-off-by: Laitron meetlq@outlook.com

@Laitr0n Laitr0n force-pushed the refactor_reconfig_container branch from dffd35d to 1bfe54c Compare January 23, 2023 05:49
@Laitr0n Laitr0n marked this pull request as ready for review January 23, 2023 05:50
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda
Copy link
Copy Markdown
Member

FAIL - commit subject exceeds 90 characters

@Laitr0n Laitr0n force-pushed the refactor_reconfig_container branch from 1bfe54c to 6652f8e Compare January 23, 2023 06:49
…ontainerutil.

Signed-off-by: Laitron <meetlq@outlook.com>
@Laitr0n Laitr0n force-pushed the refactor_reconfig_container branch from 6652f8e to 71d7b8b Compare January 23, 2023 06:50
@Laitr0n Laitr0n requested a review from AkihiroSuda January 23, 2023 06:53
@AkihiroSuda AkihiroSuda added this to the v1.2.0 milestone Jan 23, 2023
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 5815d5a into containerd:main Jan 23, 2023
@Laitr0n Laitr0n deleted the refactor_reconfig_container branch January 23, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants