logging: respect ctx#2727
Merged
Merged
Conversation
djdongjin
approved these changes
Jan 2, 2024
Member
djdongjin
left a comment
djdongjin
left a comment
There was a problem hiding this comment.
LGTM, thanks.
Also is it possible to add a test that can capture the regression and demonstrate the fix? For example, test sudo nerdctl run --rm hello-world can be finished in, e.g., 5s. (not sure if this will be flaky).
The ctx is cancelled on SIGTERM Fix issue 2726 (regression in PR 2683) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Member
Author
Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ctx is cancelled on SIGTERM
Fix #2726 (regression in #2683)