[CANARY] Disable test retries#3189
Closed
apostasie wants to merge 1 commit intocontainerd:mainfrom
Closed
Conversation
Contributor
Author
|
Of course, please do not restart any of these manually. |
apostasie
force-pushed
the
dev-ci-kill-retry
branch
5 times, most recently
from
3eae9de to
ef46b8f
Compare
apostasie
force-pushed
the
dev-ci-kill-retry
branch
6 times, most recently
from
2d0d19f to
320016c
Compare
Merged
apostasie
force-pushed
the
dev-ci-kill-retry
branch
4 times, most recently
from
9ee9715 to
d6747eb
Compare
Contributor
Author
|
Green again, but #3225 is still a clear issue before we can consider merging this. |
apostasie
force-pushed
the
dev-ci-kill-retry
branch
2 times, most recently
from
10d0659 to
01713d3
Compare
apostasie
force-pushed
the
dev-ci-kill-retry
branch
3 times, most recently
from
064f038 to
479e2f4
Compare
Contributor
Author
|
08/09/2024:
Run: https://github.com/containerd/nerdctl/actions/runs/10323534574/job/28581121980 The logs one is perplexing, but far from being the only log problem in CI. We should really have a look at logs overall. The IPFS one is also happening often - |
apostasie
force-pushed
the
dev-ci-kill-retry
branch
from
479e2f4 to
097f54a
Compare
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
dev-ci-kill-retry
branch
from
097f54a to
eba00db
Compare
Contributor
Author
|
Closing in favor of #3305 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMHO we cannot keep on hiding problems by "retrying tests" until it works.
This is a doomed approach.
I perfectly understand how painful it is to go and debug these flakyness / concurrency issues, and that it is much easier to ignore the problem - but we have to solve these - they are definitely indicative of deep quality issues and the only way to do so is to make it as obvious as possible instead of hiding it under the retry-carpet.
This is a canary PR that will very likely keep failing for some time - until we fix ALL these issues.
I will rebase it against main daily, and eventually we should get it green and stable.
Finally note that this canary is usually AHEAD of main - using commits from pending PRs fixing flakyness