[PRIORITY] Do not hard error if containers are gone#3192
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom Jul 6, 2024
Merged
[PRIORITY] Do not hard error if containers are gone#3192AkihiroSuda merged 1 commit intocontainerd:mainfrom
AkihiroSuda merged 1 commit intocontainerd:mainfrom
Conversation
Contributor
Author
|
Note: in the future, when we will be in a better position wrt CI, I will add tests to stress concurrency to ensure these problem patterns do not get reintroduced in the codebase. |
AkihiroSuda
reviewed
Jul 5, 2024
Contributor
Author
|
Note: failure seems entirely unrelated (systemd socket something) |
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Contributor
Author
|
Last run failure on integ-rootless is IPFS - these should get fixed soon with #3181 |
This was referenced Jul 6, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another instance of #3167 (see ticket for rationale - in a shell: do not assume containers are still there after a call to client.Containers...)
In that specific case, it will make
createfail if another unrelated container got removed in a racy way.It is very likely responsible for a large number of failures on the CI, and definitely strikes more with parallelization.
This very likely will address #3092, #3186, and possibly a number of others.
@AkihiroSuda @fahedouch if you are around - would appreciate a quick merge on this, preferably before other QA/CI PRs so that I can rebase and see what problems are left (specifically for the IPFS one).
Of course, I will rebase #3189 as well ASAP which should give us a good hint.
Finally, if this is as bad as I think it is, merging this should give us a good speed boost on the CI (as a lot of "retries" will no longer be necessary).
Thanks a lot!