Network prune should not fail if containers vanish#3194
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom Jul 6, 2024
Merged
Network prune should not fail if containers vanish#3194AkihiroSuda merged 1 commit intocontainerd:mainfrom
AkihiroSuda merged 1 commit intocontainerd:mainfrom
Conversation
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
changed the title
Contributor
Author
|
Back on main. 1 failure - still IPFS. This one is good to go @AkihiroSuda |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is yet another instance of #3167
This here is less urgent than #3192 as it only affects
network prune.Issue was seen 3 times on this specific canary build: https://github.com/containerd/nerdctl/actions/runs/9815148442?pr=3189
Note that this is on top of #3192 - I will rebase on main as soon as it gets merged.