Skip to content

[PRIORITY] Account for availability delay of golang docker image#3224

Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom
apostasie:dev-urgent
Jul 16, 2024
Merged

[PRIORITY] Account for availability delay of golang docker image#3224
AkihiroSuda merged 1 commit intocontainerd:mainfrom
apostasie:dev-urgent

Conversation

@apostasie
Copy link
Copy Markdown
Contributor

Fix #3223

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie apostasie changed the title Account for availability delay of golang docker image [PRIORITY] Account for availability delay of golang docker image Jul 16, 2024
@apostasie
Copy link
Copy Markdown
Contributor Author

cc @AkihiroSuda

PTAL at your earliest convenience (CI is currently broken because of #3223 )

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Jul 16, 2024
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Jul 16, 2024
@AkihiroSuda AkihiroSuda merged commit 17558b3 into containerd:main Jul 16, 2024
@apostasie
Copy link
Copy Markdown
Contributor Author

@AkihiroSuda this patch might not be enough if Docker Hub also has delays on main golang version. If that fails again for that reason and I do not notice it, please tag me and I will revise this patch by doing explicit tag availability check against Docker Hub:

curl -fsSL "https://registry-1.docker.io/v2/library/golang/tags/list" -H "Authorization: Bearer $(curl -fsSL "https://auth.docker.io/token?service=registry.docker.io&scope=repository%3Alibrary%2Fgolang%3Apull" | jq  -rc .access_token)" | jq .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci e.g., CI failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] delay between official releases of go and availability of Docker Hub image will break Canary

2 participants