Skip to content

Add delay to tentatively fix flakyness with Docker#3557

Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom
apostasie:tweak-docker-failing-test
Oct 17, 2024
Merged

Add delay to tentatively fix flakyness with Docker#3557
AkihiroSuda merged 1 commit intocontainerd:mainfrom
apostasie:tweak-docker-failing-test

Conversation

@apostasie
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: apostasie <spam_blackhole@farcloser.world>

// It appears this test flakes out with Docker seeing only "foo\n"
// Tentatively adding a pause in case this is just slow
time.Sleep(time.Second)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bug in Docker?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe - if that does not help, I ll just mark it skipped for docker

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Oct 17, 2024
@AkihiroSuda AkihiroSuda merged commit 0ac0168 into containerd:main Oct 17, 2024
@apostasie
Copy link
Copy Markdown
Contributor Author

Similar failure happened in TestStopWithStopSignal.
Documenting with #3564.

There may indeed be some bug in docker logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants