Chores#3564
Conversation
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
- containerd#3512 is likely fixed, so, deflaking test - a couple of other circumstances failed the build (one of them with Docker) - commenting in-line - marking another instance of containerd#3524 Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
| testCase.Require = test.Require( | ||
| testCase.Require, | ||
| nerdtest.IsFlaky("https://github.com/containerd/nerdctl/issues/3524"), | ||
| ) |
There was a problem hiding this comment.
Sure.
On windows, this may fail (randomly) - detailed in the linked ticket.
nerdtest.IsFlaky("issue link") is part of the new test framework (https://github.com/containerd/nerdctl/blob/main/docs/testing/tools.md#requirements)
It marks a test as flaky, which makes it run only if -test.only-flaky is provided to the integration test.
Very soon, with PR #3535 we will have separate steps to run non-flaky (no retries, hard failure) and flaky tests (retries, hard fail only if all retries fail).
Now, this test also has a requirement of not(docker):
and I do not want that to get overridden here (otherwise, if ran on windows against target docker, the test would not be skipped).
test.Require(reqs...) is a helper that just bundles together a set of requirements (the previous one testCase.Require, and the conditional one IsFlaky).
Lmk if that does not clarify or if your question was about something I missed?
Thanks @djdongjin
3 participants
This contains some changes broken out of #3550 (while it is being reviewed, we can still get these in and I will rebase)