Skip to content

Rewrite container_top tests#3612

Merged
AkihiroSuda merged 2 commits into
containerd:mainfrom
apostasie:series-10
Nov 1, 2024
Merged

Rewrite container_top tests#3612
AkihiroSuda merged 2 commits into
containerd:mainfrom
apostasie:series-10

Conversation

@apostasie
Copy link
Copy Markdown
Contributor

@apostasie apostasie commented Oct 29, 2024 •
edited
Loading

On top of #3617

@apostasie apostasie changed the title Rewrite container_top tests [WIP] Rewrite container_top tests Oct 29, 2024
@apostasie apostasie changed the title [WIP] Rewrite container_top tests [BROKEN] Rewrite container_top tests Oct 29, 2024
@apostasie apostasie force-pushed the series-10 branch 6 times, most recently from c419bdf to e40d182 Compare October 30, 2024 19:46
@apostasie
Copy link
Copy Markdown
Contributor Author

apostasie commented Oct 30, 2024

Failure is connectivity issue with ECR

        time="2024-10-30T19:57:47Z" level=fatal msg="failed to resolve reference \"public.ecr.aws/soci-workshop-examples/ffmpeg:latest\": failed to do request: Head \"[https://public.ecr.aws/v2/soci-workshop-examples/ffmpeg/manifests/latest\](https://public.ecr.aws/v2/soci-workshop-examples/ffmpeg/manifests/latest/)": net/http: TLS handshake timeout"```

@apostasie apostasie changed the title [BROKEN] Rewrite container_top tests Rewrite container_top tests Oct 30, 2024
@apostasie apostasie marked this pull request as ready for review October 30, 2024 21:00
AkihiroSuda
AkihiroSuda reviewed Oct 31, 2024
View reviewed changes
Comment thread cmd/nerdctl/container/container_commit_test.go
@apostasie
Remove fixed-bug workaround
5419664 
Fixed in containerd#3618

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie
Rewrite container_top tests
4760ee9 
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie apostasie requested a review from AkihiroSuda October 31, 2024 11:35
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Oct 31, 2024
AkihiroSuda
AkihiroSuda approved these changes Nov 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit bc0739d into containerd:main Nov 1, 2024
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/ci e.g., CI failure

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@apostasie @AkihiroSuda