Refactor: suggesting we normalize all command variables to cmd #3913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
changed the title
apostasie
changed the title
apostasie
force-pushed
the
refactor-cmd-1
branch
from
8684351 to
cedb8a9
Compare
Contributor
Author
|
Rebased. |
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
refactor-cmd-1
branch
from
cedb8a9 to
b41e8c9
Compare
AkihiroSuda
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple, purely cosmetic PR, harmonizing all command variables to
var cmd(under the cmd folder).The proposed cleanup enhances code readability and removes what is currently just noise.
If this is something we think is good, more PRs will follow that focus on the same topic overall: cleanups / reorgs fostering simplicity and code readability.
Let me know your thoughts.