Refactor: cleanup cmd variable names #3944
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion following on #3913
These changes are purely cosmetic, and their purpose is to increase code readability, by removing stuttering information from variables and functions name (following the refactor of cmd this last summer), and overall simplifying names.
This applies solely to
cmd/For now, these changes are solely onapparmor, so that we can talk about them.If this is the right thing to do and we agree on the changes, I will apply them to the entirety ofcmdand submit a complete / working PR.The proposed changes are:
newThingPackageCommandfunction names tothingCommand:packageThingActionfunction names tothingActionprocessPackageThingOptionsfunction names tothingOptionsNewPackageCommandunique functions toCommandLs,Rm, toList,Removewhere applicableReasoning is that:
Packagealways stutter now that they are split undercmdnew, orprocessdoes not add much value if any and is just noisyThanks.
Tagging @AkihiroSuda for opinion.