Skip to content

Conversation

@apostasie
Copy link
Contributor

@apostasie apostasie commented Mar 5, 2025

For context, see #3940, #3924, and the start of this PR cycle at #3983.

On top of #3984


We currently shard our cache per-containerd version.

There is more downsides than upsides in doing this. Specifically:

  • it does multiply our cache use by as many versions of containerd we are testing (currently three, soon two)
  • because we are more likely to hit GHA limits, this triggers cascading cache evictions, forcing unnecessary full rebuilds and further increasing communication with the cache backend, leading to throttling

While not sharding and running in parallel will indeed drop some layers that could be cached until the cache is fully warm, this should be out-weighted by the benefits.

@apostasie
Copy link
Contributor Author

EL8 failure is TestStopWithStopSignal - see #3979

@apostasie apostasie changed the title [WIP] Stop sharding cache on containerd [WIP] CI, build 3: Stop sharding cache on containerd Mar 5, 2025
@apostasie apostasie changed the title [WIP] CI, build 3: Stop sharding cache on containerd CI, build 3: Stop sharding cache on containerd Mar 5, 2025
@apostasie apostasie marked this pull request as ready for review March 5, 2025 01:04
@apostasie apostasie changed the title CI, build 3: Stop sharding cache on containerd CI, build 3: Stop sharding cache on containerd version Mar 5, 2025
@apostasie
Copy link
Contributor Author

Failure is #3513

@AkihiroSuda AkihiroSuda added this to the v2.0.4 milestone Mar 7, 2025
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Mar 7, 2025
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Copy link
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need rebase

@apostasie apostasie requested a review from djdongjin March 13, 2025 16:34
@djdongjin djdongjin merged commit 497c7cf into containerd:main Mar 13, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci e.g., CI failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants