CI, build 4: Cleanup Dockerfile base images #3986
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
force-pushed
the
ci-build-accel-4
branch
4 times, most recently
from
f545aaf to
65b6293
Compare
apostasie
changed the title
apostasie
changed the title
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
ci-build-accel-4
branch
from
65b6293 to
ef1c2f0
Compare
AkihiroSuda
reviewed
Mar 7, 2025
| ENV TERM="xterm" | ||
| ENV LANG="C.UTF-8" | ||
| ENV LC_ALL="C.UTF-8" | ||
| ENV TZ="America/Los_Angeles" |
AkihiroSuda
reviewed
Mar 7, 2025
| FROM --platform=$BUILDPLATFORM debian:$DEBIAN_VERSION AS tooling-base | ||
| SHELL ["/bin/bash", "-o", "errexit", "-o", "errtrace", "-o", "functrace", "-o", "nounset", "-o", "pipefail", "-c"] | ||
| ENV DEBIAN_FRONTEND="noninteractive" | ||
| ENV TERM="xterm" |
AkihiroSuda
reviewed
Mar 7, 2025
| SHELL ["/bin/bash", "-o", "errexit", "-o", "errtrace", "-o", "functrace", "-o", "nounset", "-o", "pipefail", "-c"] | ||
| ENV DEBIAN_FRONTEND="noninteractive" | ||
| ENV TERM="xterm" | ||
| ENV LANG="C.UTF-8" |
Member
There was a problem hiding this comment.
Isn't this the default locale?
AkihiroSuda
reviewed
Mar 7, 2025
| ENTRYPOINT ["/docker-entrypoint.sh"] | ||
| CMD ["bash", "--login", "-i"] | ||
|
|
||
| # convert GO_VERSION=1.16 to the latest release such as "go1.16.1" |
Member
There was a problem hiding this comment.
AkihiroSuda
reviewed
Mar 7, 2025
| echo "Failed retrieving go download for $arch: $GO_VERSION"; \ | ||
| exit 1; \ | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
This complicates the Dockerfile too much
AkihiroSuda
requested changes
Mar 7, 2025
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
Sorry, I don't get the advantages of this
Member
Yes, but usually fixed within a day |
This was referenced Mar 7, 2025
Member
|
Alternative: |
Contributor
Author
Commented briefly on #3997 The point is that our current Dockerfile is retrieving massive amount of data for no good reason, and heavily depends on Hub for stuff that is very easy to do without. We just disagree on the way to tackle these problems, so, I'll just retract this proposal. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, see #3940, #3924, and the start of this PR cycle at #3983.
On top of #3985
We currently depend on two distincts golang image (bookworm and alpine), and we also download a golang archive from go servers.
Depending at all on docker images is a significant source of issues:
This PR does cleanup our base images.
It bases every build stage on a single image, a naked bookworm, and uses the golang version of go.
That will reduce our network traffic with Hub, improve cacheability, and make our life less miserable when new versions of go arrive.
Finally, this will drastically reduce network com with go servers, as currently the archive is never cached and always downloaded, for every target we build. There should be a speed boost out of that for the later build stages.
(*) this PR does fix the current canary bustage