Skip to content

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Mar 7, 2025

No need to fetch https://golang.org/dl/$(cat /GOVERSION)... when we can just copy /usr/local/go from the golang:${GO_VERSION} image.

Alternative to:

@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Mar 7, 2025
@AkihiroSuda AkihiroSuda added this to the v2.0.4 milestone Mar 7, 2025
@AkihiroSuda AkihiroSuda force-pushed the refactor-dockerfile-goversion branch 3 times, most recently from 0666ad0 to 8f57293 Compare March 7, 2025 07:38
No need to fetch `https://golang.org/dl/$(cat /GOVERSION)...`
when we can just copy `/usr/local/go` from the `golang:${GO_VERSION}` image.

Alternative to PR 3986

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda force-pushed the refactor-dockerfile-goversion branch from 8f57293 to e33a85f Compare March 7, 2025 07:43
@apostasie
Copy link
Contributor

This is increasing our reliance on Hub content instead of decreasing it, and adding unnecessary intermediary layers and dependent infrastructure with no added value.

@AkihiroSuda
Copy link
Member Author

This is increasing our reliance on Hub content instead of decreasing it, and adding unnecessary intermediary layers and dependent infrastructure with no added value.

This PR just reuses an existing build-base-debian stage, so the reliance of Hub isn't changed, and it does not add a new intermediate layer.

Copy link
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdongjin djdongjin merged commit e450a1c into containerd:main Mar 9, 2025
30 checks passed
@apostasie
Copy link
Contributor

This is increasing our reliance on Hub content instead of decreasing it, and adding unnecessary intermediary layers and dependent infrastructure with no added value.

This PR just reuses an existing build-base-debian stage, so the reliance of Hub isn't changed, and it does not add a new intermediate layer.

The point is:

  • we use two distinct golang images from Hub
  • we are now copying go from the debian image as-is to an ubuntu image - while presumably it is not a problem if all they are doing is retrieving it from golang server - and then if it is all they are doing, it then begs the question as to why we should rely on an extra intermediary piece of infrastructure (Hub) to do a curl for us (with availability delays and versioning scheme differences)

I guess we just disagree on this overall, so, this is fine, no point in beating this.

I just wish we would look at all of this critically.

We are currently retrieving about 6G of content from the network on a cold cache (out of which about 1G comes from Hub).
This is a very large amount of data that does not make much sense IMHO - and explains in part why we are getting 429 from Hub so regularly.

Anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci e.g., CI failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants