Skip to content

Conversation

@apostasie
Copy link
Contributor

No description provided.

@apostasie apostasie force-pushed the ci-build-accel-6 branch 26 times, most recently from ea0ae7f to c8fba63 Compare March 6, 2025 18:55
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie apostasie force-pushed the ci-build-accel-6 branch 13 times, most recently from 03f0c07 to d9eeb54 Compare March 7, 2025 00:52
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@AkihiroSuda
Copy link
Member

Alternative for the Go version hack:

@AkihiroSuda
Copy link
Member

Also, I thought the direction was to remove the integration test stages from the Dockerfile eventually.
So, the Go version for the integration test can be just specified as "1.24.x" in the GHA yamls.

The Go version for the building the binaries will still have to be specified in the Dockerfile, but probably there is no need to add Go installer to the Makefile.

@apostasie
Copy link
Contributor Author

Also, I thought the direction was to remove the integration test stages from the Dockerfile eventually. So, the Go version for the integration test can be just specified as "1.24.x" in the GHA yamls.

The runtime test stage, yes - not the build part IMHO.

Retracting (see #3986 )

@apostasie apostasie closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants