COPY --chown: expand the conformance test#3095
Merged
openshift-merge-robot merged 2 commits intocontainers:masterfrom Mar 23, 2021
Merged
COPY --chown: expand the conformance test#3095openshift-merge-robot merged 2 commits intocontainers:masterfrom
openshift-merge-robot merged 2 commits intocontainers:masterfrom
Conversation
openshift-ci-robot
added
kind/bug
nalind
force-pushed
the
user-spec
branch
3 times, most recently
from
9dfb6ab to
bec92c7
Compare
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Use a bufio Scanner rather than our own cobbled-together read-a-line-at-a-time function. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Expand conformance test coverage for COPY --chown, and correct our behavior when the argument is a single number: instead of assuming the number is the UID and GID = 0, the GID should be the same as the UID. This means that we can't quite use the same function for parsing the arguments for COPY --chown and USER, as they evidently have different defaults for the case where the argument is a single number. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Member
|
LGTM |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Expand conformance test coverage for COPY --chown, and correct our behavior when the argument is a single number: instead of assuming the number is the UID and the GID = 0, the GID should be the same as the UID.
How to verify it
New conformance test!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Grew out of the conformance tests for openshift/imagebuilder#188.
Does this PR introduce a user-facing change?