Skip to content

dockerclient: implement --chown for ADD/COPY#188

Merged
rhatdan merged 1 commit intoopenshift:masterfrom
nalind:chown
Mar 24, 2021
Merged

dockerclient: implement --chown for ADD/COPY#188
rhatdan merged 1 commit intoopenshift:masterfrom
nalind:chown

Conversation

@nalind
Copy link
Copy Markdown
Member

@nalind nalind commented Mar 22, 2021

Fixes #187.

@openshift-ci-robot
Copy link
Copy Markdown

@nalind: This pull request references Bugzilla bug 1937087, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1937087: dockerclient: implement --chown for ADD/COPY

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 22, 2021
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2021
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Mar 22, 2021

/retitle dockerclient: implement --chown for ADD/COPY

@openshift-ci-robot openshift-ci-robot changed the title Bug 1937087: dockerclient: implement --chown for ADD/COPY dockerclient: implement --chown for ADD/COPY Mar 22, 2021
@openshift-ci-robot
Copy link
Copy Markdown

@nalind: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

dockerclient: implement --chown for ADD/COPY

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 22, 2021
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@rhatdan
Copy link
Copy Markdown
Contributor

rhatdan commented Mar 23, 2021

LGTM
@umohnani8 @TomSweeneyRedHat PTAL

@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor

LGTM
It took me a hot minute to figure out what was going on in the conformance test, that's pretty nifty.

@rhatdan rhatdan merged commit 17b7bf5 into openshift:master Mar 24, 2021
@nalind nalind deleted the chown branch March 24, 2021 13:40
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Mar 24, 2021

Eek, that last line in the Dockerfile isn't relevant, and it's just dumb luck that the util-linux package provided a /usr/bin/script that kept the test from failing to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

COPY --chown does not work right

4 participants