Remove dependency of c/image/manifest on pkg/compression #1310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This will allow decreasing the impact in openshift/oc#737 , at least. Sadly any c/image/docker client still drags in all the compression implementations, per #1146 (comment) . |
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... to make the lines shorter. We will soon make them even longer, so fold them separately to make the actual change easier to review. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
For some reason (??), the Xz algorithm's name starts with an upper-case letter; use the same for InternalUnstableUndocumentedMIMEQuestionMark . AFAICS this should not make a difference because InternalUnstableUndocumentedMIMEQuestionMark is only used for MIME mapping, and xz is not present in any of those tables, so this is only for consistency. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... so that code can refer to them without depending on the actual decompression implementations, which might not be necessary for various metadata operations. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Most importantly this removes a dependency of c/image/manifest (and thus c/image/signature) on pkg/compression and all the implementations. Use pkg/compression/types everywhere else it is possible as well, even if it does not remove any dependency on pkg/compression, just to enforce the discipline. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Member
|
LGTM |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A partial fix for a #1146 . See individual commit messages for details.