Bug 1949050: Update containers/image

[mtrmac]

… in two steps:

• Revert the only user of openshift/containers-image to the original repo (still using a very old v3.0.2)
• Update to v5.10.2 (which is relevant to oc adm verify-image-signature by adding a new identity mapping feature); sadly, this drags in various compression implementations that are not actually used.

The first part might affect development on Mac, because go test and the like (not mediated through Makefile) would require manually specifying the containers_image_openpgp tag, or installing gpgme (brew install gpgme).

Implemented as two separate commits, so you can choose to include only the first one. See individual commit messages for details.

[mtrmac]

/retest

[mtrmac]

• sadly, this drags in various compression implementations that are not actually used.

Filed containers/image#1146 .

[mtrmac]

/retest

[mtrmac]

/retest

[sttts]

manually specifying the containers_image_openpgp tag, or installing gpgme (brew install gpgme).

Do make print a good error message for this?

[mtrmac]

make just works (uses the tag). (Well, it fails for me because I don’t have some GSS dependencies.)

Things like this, not using make, (building that package, or probably anything that depends on it) fail:

% go build -a ./pkg/cli/admin/verifyimagesignature
# github.com/mtrmac/gpgme
vendor/github.com/mtrmac/gpgme/data.go:4:11: fatal error: 'gpgme.h' file not found
 #include <gpgme.h>
          ^~~~~~~~~
1 error generated.

[mtrmac]

/retest

[soltysh]

I'd like to see openshift/origin#25880 land first, since that will enable verify test. Secondly, can you split the commit with bump from the actual change to oc, I know it's just a single file (pkg/cli/admin/verifyimagesignature/verify-signature.go) it's for readability 😉

[mtrmac]

Secondly, can you split the commit with bump from the actual change to oc

Like this? It’s a module major version bump (although the changes don’t impact this code), so at the middle commit, the repo does not build.

[mtrmac]

/retest

[mtrmac]

/retest

[soltysh]

Like this? It’s a module major version bump (although the changes don’t impact this code), so at the middle commit, the repo does not build.

Prefect! I wouldn't worry about middle build, it's just easier to review when you separate automated changes from manual ones.

[mtrmac]

/retest

[mtrmac]

/retest

[mtrmac]

/retest

[mtrmac]

/retest

[mtrmac]

I'd like to see openshift/origin#25880 land first, since that will enable verify test.

This has now been merged.

[mtrmac]

/retest

[mtrmac]

/retest

[openshift-ci-robot]

@mtrmac: This pull request references Bugzilla bug 1949050, which is invalid:

• expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1949050: Update containers/image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[soltysh]

/bugzilla refresh
/override ci/prow/e2e-agnostic-cmd
the failure is being fixed and is unrelated to this PR

[openshift-ci-robot]

@soltysh: This pull request references Bugzilla bug 1949050, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

/bugzilla refresh
/override ci/prow/e2e-agnostic-cmd
the failure is being fixed and is unrelated to this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-agnostic-cmd

Details

In response to this:

/bugzilla refresh
/override ci/prow/e2e-agnostic-cmd
the failure is being fixed and is unrelated to this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[soltysh]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@mtrmac: Some pull requests linked via external trackers have merged:

• openshift/oc#737

The following pull requests linked via external trackers have not merged:

• openshift/origin#26060 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1949050 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1949050: Update containers/image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.