Bug 1949050: bump(k8s.io/*): 1.21 #26054
Conversation
openshift-ci-robot
added
the
approved
|
You should be able to absorb #25833 into this. (It was waiting for an openshift/kubernetes PR to merge, but the upstream commit it was waiting for is in 1.21.) |
I'd prefer to solve it separately, to minimize the noise I'm currently dealing with coming from this PR. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
openshift-ci-robot
added
bugzilla/severity-high
|
@soltysh: This pull request references Bugzilla bug 1949050, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cmd/openshift-tests/images.go
Outdated
|
|
||
| // exceptions is a list of images we don't mirror temporarily due to various | ||
| // problems. This list should ideally be empty. | ||
| var exceptions = sets.NewString( |
There was a problem hiding this comment.
Move this to the test/util/image package, not here
There was a problem hiding this comment.
Moved in the last push.
|
/retest |
|
/retest |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/retest |
|
/lgtm Thank you for working on this @soltysh |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, ravisantoshgudimetla, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-aws-csi |
|
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-csi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@soltysh: All pull requests linked via external trackers have merged:
Bugzilla bug 1949050 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
14 participants
No description provided.