Bug 1896558: bump(openshift/kubernetes): multi-az spreading e2e flakes #25915
Conversation
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@damemi: This pull request references Bugzilla bug 1896558, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
|
@damemi: This pull request references Bugzilla bug 1896558, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/retest |
damemi
force-pushed
the
bump-multiaz-fixes
branch
from
13f2b0a to
91d4ca0
Compare
|
Updated to bump all kubernetes deps... build failures looked like some incompatibility with just bumping o/k |
| github.com/davecgh/go-spew v1.1.1 | ||
| github.com/docker/distribution v2.7.1+incompatible | ||
| github.com/fsouza/go-dockerclient v0.0.0-20171004212419-da3951ba2e9e | ||
| github.com/fsouza/go-dockerclient v1.6.6-0.20200611205848-6aaf6c2d625c |
There was a problem hiding this comment.
Need to bump this as well, otherwise go mod tidy fails:
go: finding module for package github.com/docker/libnetwork/ipamutils
go: found github.com/docker/libnetwork/ipamutils in github.com/docker/libnetwork v0.5.6
go: finding module for package github.com/Sirupsen/logrus
go: found github.com/Sirupsen/logrus in github.com/Sirupsen/logrus v1.8.0
go: github.com/openshift/origin/test/extended/images imports
github.com/fsouza/go-dockerclient imports
github.com/docker/docker/opts imports
github.com/docker/libnetwork/ipamutils imports
github.com/docker/libnetwork/osl imports
github.com/Sirupsen/logrus: github.com/Sirupsen/logrus@v1.8.0: parsing go.mod:
module declares its path as: github.com/sirupsen/logrus
but was required as: github.com/Sirupsen/logrus
ab9cea6 to
376ce44
Compare
origin needs to have its golang version updated in order to bump the openshift deps. @soltysh is this something we can do? |
|
@damemi: This pull request references Bugzilla bug 1896558, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
damemi
force-pushed
the
bump-multiaz-fixes
branch
from
e9677d1 to
5bc2e8d
Compare
|
Ok, I don't actually need the build-machinery-go bump. edit: this actually needs openshift/kubernetes#616 to fix o/k, so that library-go doesn't depend on our forked version |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
What's the status of this? I just tried myself on #25997 and running into the things you seem to have already solved :) Any chance to bump openshift/kubernetes here to include openshift/kubernetes#628? |
|
@stbenjam talking to @sttts this depends on fixing a change made to o/k (openshift/kubernetes#616). Without it, the version of kubernetes vendored by origin does not compile with the vendored library-go Afaict, the |
|
openshift/kubernetes#616 has landed! |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold
|
openshift-ci-robot
added
the
do-not-merge/hold
|
maybe the |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
@damemi: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
pods are being killed by OOM |
|
The ingress ones seems to fail because they assume there is no default ingress class |
|
@soltysh: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@damemi: This pull request references Bugzilla bug 1896558. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@aojea thanks for finding that, OOM is interesting since these are using just small test images. I wonder if the memory limits are being set too low (and if we even need limits for the scheduler to see the nodes as balanced, or if it only works on requests) @soltysh if you hit this again in your PR we will have to debug further |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/invalid-bug
|
@damemi: This pull request references Bugzilla bug 1896558, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Hopefully also addresses https://bugzilla.redhat.com/show_bug.cgi?id=1929389
Pulls changes from openshift/kubernetes#526