-
Notifications
You must be signed in to change notification settings - Fork 395
OCI ImageDestination #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7e177a1 to
1a88b53
Compare
|
.ACK, pending the MIME type flexibility to make |
|
Will the creation of the ref and the oci-layout file be added in a future PR? Will the ref be mapped to the docker tag? |
| return err | ||
| } | ||
| // TODO(runcom): ugly here? | ||
| if err := ioutil.WriteFile(ociLayoutPath(d.dir), []byte(`{"imageLayoutVersion": "1.0.0"}`), 0644); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgotti what you asked is here, oci-layout and ref which comes from the docker tag/digest in case the ImageSource is a docker ImageSource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@runcom that means that I shouldn't look at github diffs from a phone 😜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely :)
edd61c8 to
c86453e
Compare
|
rebased to have mime types flexibility bits /cc @mtrmac |
dd12c91 to
e380fa8
Compare
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
|
@mtrmac ready to review |
|
The test against skopeo will be in containers/skopeo#133 |
|
skopeo's working fine: |
/cc @mtrmac @sgotti
There are still a couple of stuff to be taken care of here but pls review and comment if you can
Most notably we need to take care of containers/skopeo#102 (comment) /cc @mtrmac
Signed-off-by: Antonio Murdaca runcom@redhat.com