-
Notifications
You must be signed in to change notification settings - Fork 395
Add (make test-skopeo) and run it in Travis CI #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
(First Travis run, let’s see if this works at all…) |
| SKOPEO_REPO = projectatomic/skopeo | ||
| SKOPEO_BRANCH = master | ||
| # Set SUDO=sudo to run container integration tests using sudo. | ||
| SUDO = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ambivalent about the default value. Personally SUDO = sudo would make my life easier, but the empty string default is less surprising, and on systems which do not need root privileges to use Docker this does not gain unnecessary privileges and is not unexpectedly interactive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way works for me
|
… huh, Travis tests the branch against latest |
|
So are we waiting on #23 and containers/skopeo#133 to merge this eventually? |
|
Yes. I guess we could do without #23 but the blocker is containers/skopeo#133 anyway IIUC. |
58f6234 to
a969aab
Compare
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
👍 Finally, both are in sync and this works. @runcom , can we please merge this before changing anything else about containers/image and before the two get out of sync again? |
Note that this is branched against commit 1a7569b , not latest
master; latestmastercurrently breaksskopeo(pending containers/skopeo#133 ).Fixes #13 .