Skip to content

Conversation

@mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Jun 29, 2016

Note that this is branched against commit 1a7569b , not latest master; latest master currently breaks skopeo (pending containers/skopeo#133 ).

Fixes #13 .

@mtrmac
Copy link
Collaborator Author

mtrmac commented Jun 29, 2016

(First Travis run, let’s see if this works at all…)

SKOPEO_REPO = projectatomic/skopeo
SKOPEO_BRANCH = master
# Set SUDO=sudo to run container integration tests using sudo.
SUDO =
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ambivalent about the default value. Personally SUDO = sudo would make my life easier, but the empty string default is less surprising, and on systems which do not need root privileges to use Docker this does not gain unnecessary privileges and is not unexpectedly interactive.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way works for me

@mtrmac
Copy link
Collaborator Author

mtrmac commented Jun 29, 2016

… huh, Travis tests the branch against latest master? Anyway, close enough to working for now, will rebase as needed.

@runcom
Copy link
Member

runcom commented Jun 29, 2016

So are we waiting on #23 and containers/skopeo#133 to merge this eventually?

@mtrmac
Copy link
Collaborator Author

mtrmac commented Jun 29, 2016

Yes. I guess we could do without #23 but the blocker is containers/skopeo#133 anyway IIUC.

@mtrmac mtrmac force-pushed the test-skopeo branch 2 times, most recently from 58f6234 to a969aab Compare July 1, 2016 22:37
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Copy link
Collaborator Author

mtrmac commented Jul 4, 2016

👍 Finally, both are in sync and this works.

@runcom , can we please merge this before changing anything else about containers/image and before the two get out of sync again?

Approved with PullApprove

@runcom
Copy link
Member

runcom commented Jul 4, 2016

lgtm

Approved with PullApprove

@runcom runcom merged commit 295e38d into containers:master Jul 4, 2016
@mtrmac mtrmac deleted the test-skopeo branch July 4, 2016 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants