Mark containers invalid earlier during removal#1001
Closed
mheon wants to merge 1 commit into
Closed
Conversation
Fixes a bug where we might try saving back to the database during cleanup, which would fail as the container was already removed from the database. Signed-off-by: Matthew Heon <mheon@redhat.com>
Member
|
LGTM |
Member
Member
Collaborator
|
📌 Commit 2ed08d5 has been approved by |
This was referenced Jun 26, 2018
Member
|
@rh-atomic-bot retry |
Collaborator
|
⌛ Testing commit 2ed08d5 with merge 2c2c576... |
Member
|
@rh-atomic-bot retry |
Collaborator
|
⌛ Testing commit 2ed08d5 with merge f87dcad... |
Collaborator
|
☀️ Test successful - status-papr |
Collaborator
|
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
Member
|
bot, retest this please |
Member
Author
|
@rh-atomic-bot retry |
Collaborator
|
⚡ Test exempted: merge already tested. |
github-actions
Bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where we might try saving back to the database during cleanup, which would fail as the container was already removed from the database.