container_internal: don't ignore error from cleanupNetwork()#1002
container_internal: don't ignore error from cleanupNetwork()#1002giuseppe wants to merge 1 commit into
Conversation
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
LGTM once tests green |
|
📌 Commit f22db58 has been approved by |
|
⌛ Testing commit f22db58 with merge 3c83570... |
| // Clean up network namespace, if present | ||
| if err := c.cleanupNetwork(); err != nil { | ||
| lastError = nil | ||
| lastError = err |
There was a problem hiding this comment.
This had been non-fatal since #302, but I don't see any discussion there about why it was non-fatal then.
There was a problem hiding this comment.
The only think I can think of was there is an issue where the cleanupNetwork can return an error that states the network does not exist, since it was cleaned up previously but there is no current way for us to check for that error because the oci network code does not use constants.
There was a problem hiding this comment.
I think were were just being overly cautious there, given that we were already only warning on errors from teardownNetwork() in cleanupNetwork().
|
I'll probably need to rebase on top of #1001 before tests are happy |
|
💔 Test failed - status-papr |
|
Test failure are #1001 - retrigger the merge once that's in and it should be good |
|
LGTM once merge and test happiness is complete. |
|
Alright, #1001 is merged. |
|
☀️ Test successful - status-papr |
github-actions
Bot
added
the
locked - please file new issue/PR
6 participants
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com