cleanup network stack as well as storage when container shuts down.#302
Merged
Conversation
mheon
reviewed
Feb 6, 2018
Member
There was a problem hiding this comment.
Need to also clear a few things in the DB after this - c.state.NetNS, c.state.IPAddress, c.state.SubnetMask. And probably need to do a c.save() afterwards to get that into the DB.
Member
Author
Member
|
LGTM |
Member
Author
|
bot, retest this please |
Member
|
bot, retest this please |
Member
Author
|
@rh-atomic-bot r=baude |
Collaborator
|
📌 Commit 4c5df84 has been approved by |
Collaborator
|
⌛ Testing commit 4c5df84 with merge aec39e3... |
Collaborator
|
💔 Test failed - status-papr |
Member
Author
|
@rh-atomic-bot retry |
Member
Author
|
bot, retest this please |
Collaborator
|
⌛ Testing commit 4c5df84 with merge ff33350... |
Member
Author
|
@rh-atomic-bot r=baude |
Collaborator
|
📌 Commit 901e73c has been approved by |
Collaborator
|
⌛ Testing commit 901e73c with merge f315dac... |
Collaborator
|
💥 Test timed out |
Member
Author
|
@rh-atomic-bot retry |
This patch will cleanup the network stack when the container exits Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Member
Author
|
bot, retest this please |
Member
|
@rh-atomic-bot retry |
Member
|
Homu broken, tests green, going to manually merge. |
github-actions
Bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch will cleanup the network stack when the container exits
Signed-off-by: Daniel J Walsh dwalsh@redhat.com