Skip to content

Change pause so only running containers are valid#309

Merged
rhatdan merged 1 commit into
containers:masterfrom
mheon:pause_state_error
Feb 7, 2018
Merged

Change pause so only running containers are valid#309
rhatdan merged 1 commit into
containers:masterfrom
mheon:pause_state_error

Conversation

@mheon
Copy link
Copy Markdown
Member

@mheon mheon commented Feb 7, 2018

It's nonsensical to pause containers that are not running

Signed-off-by: Matthew Heon <mheon@redhat.com>
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Feb 7, 2018

LGTM

Copy link
Copy Markdown
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming happy tests.

@mheon
Copy link
Copy Markdown
Member Author

mheon commented Feb 7, 2018

Tests are green, merging
@rh-atomic-bot r=rhatdan

@rh-atomic-bot
Copy link
Copy Markdown
Collaborator

📌 Commit ca7ebca has been approved by rhatdan

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Feb 7, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@rh-atomic-bot
Copy link
Copy Markdown
Collaborator

📌 Commit ca7ebca has been approved by rhatdan

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Feb 7, 2018

@rh-atomic-bot retry

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Feb 7, 2018

Homu seems hung. Merging Manually.

@rhatdan rhatdan merged commit 11eb18c into containers:master Feb 7, 2018
baude pushed a commit to baude/podman that referenced this pull request Aug 31, 2019
Flannel: Pass through runtimeConfig to delegate
@github-actions github-actions Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants