Skip to content

generate kube with volumes#3472

Merged
openshift-merge-robot merged 5 commits into
containers:masterfrom
haircommander:generate-volumes
Jul 4, 2019
Merged

generate kube with volumes#3472
openshift-merge-robot merged 5 commits into
containers:masterfrom
haircommander:generate-volumes

Conversation

@haircommander
Copy link
Copy Markdown
Collaborator

@haircommander haircommander commented Jul 2, 2019 •
edited
Loading

Add volume functionality for generate kube, including adding the fields for containers, as well as the pod. Test added as well
Fixes: #2303

@haircommander
Configure container volumes for generate kube
1307e96 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
Pass along volumes to pod yaml
aa9de67 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@mheon
Copy link
Copy Markdown
Member

mheon commented Jul 2, 2019

/approve

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Jul 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019
mheon
mheon reviewed Jul 2, 2019
View reviewed changes
Comment thread libpod/kube.go Outdated
Copy link
Copy Markdown
Member

@mheon mheon Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, what's going on here? We're getting devices... and then throwing an error that they're not supported?

Copy link
Copy Markdown
Member

@rhatdan rhatdan Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be a warning?

Copy link
Copy Markdown
Collaborator Author

@haircommander haircommander Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO Enable when we can support devices and their names I assume the translation isn't clear for libpod devices to kube devices?

mheon
mheon reviewed Jul 2, 2019
View reviewed changes
Comment thread libpod/kube.go Outdated
@haircommander
Deduplicate volumes
db2cc36 
for containers that share volumes, so the pod section doesn't list copies

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
Copy link
Copy Markdown
Collaborator Author

haircommander commented Jul 2, 2019

/test images

mheon
mheon reviewed Jul 2, 2019
View reviewed changes
Comment thread test/e2e/generate_kube_test.go Outdated
@haircommander
Add test for generate kube with volumes
341f5e2 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
Improve parsing of mounts
aeabc45 
Specifically, we were needlessly doing a double lookup to find which config mounts were user volumes. Improve this by refactoring a bit of code from inspect

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@mheon
Copy link
Copy Markdown
Member

mheon commented Jul 3, 2019

Changes LGTM

@haircommander
Copy link
Copy Markdown
Collaborator Author

haircommander commented Jul 3, 2019

@baude @jwhonce PTAL

@mheon
Copy link
Copy Markdown
Member

mheon commented Jul 4, 2019

@baude @jwhonce @rhatdan @TomSweeneyRedHat @vrothberg Can we get this landed? I'm messing around in Inspect and I don't want to make merge conflicts...

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

TomSweeneyRedHat commented Jul 4, 2019

Changes LGTM, if you're happy with the one question you had @mheon, feel free to merge it.
At some point, I'd like to see some expanded doc covering this new functionality.

@mheon
Copy link
Copy Markdown
Member

mheon commented Jul 4, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2019
@openshift-merge-robot openshift-merge-robot merged commit f7407f2 into containers:master Jul 4, 2019
@rh-atomic-bot rh-atomic-bot mentioned this pull request Jul 4, 2019
Merged
@github-actions github-actions Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rhatdan rhatdan rhatdan left review comments

@mheon mheon mheon left review comments

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@mheon mheon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

generate kube with containers having volumes

6 participants

@haircommander @mheon @openshift-ci-robot @TomSweeneyRedHat @rhatdan @openshift-merge-robot