Skip to content

code cleanup#3496

Merged
openshift-merge-robot merged 1 commit into
containers:masterfrom
baude:golandcodeinspect
Jul 8, 2019
Merged

code cleanup#3496
openshift-merge-robot merged 1 commit into
containers:masterfrom
baude:golandcodeinspect

Conversation

@baude
Copy link
Copy Markdown
Member

@baude baude commented Jul 3, 2019

clean up code identified as problematic by golands inspection

Signed-off-by: baude bbaude@redhat.com

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L labels Jul 3, 2019
@baude baude force-pushed the golandcodeinspect branch from c9e8eef to cf4c498 Compare July 4, 2019 00:25
@rh-atomic-bot
Copy link
Copy Markdown
Collaborator

rh-atomic-bot commented Jul 4, 2019

☔ The latest upstream changes (presumably #3472) made this pull request unmergeable. Please resolve the merge conflicts.

@baude baude force-pushed the golandcodeinspect branch from cf4c498 to 0ff5036 Compare July 5, 2019 13:37
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2019
@baude baude force-pushed the golandcodeinspect branch from 0ff5036 to e1dc0ea Compare July 5, 2019 13:41
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2019
@baude
Copy link
Copy Markdown
Member Author

baude commented Jul 5, 2019

/test images

1 similar comment
@baude
Copy link
Copy Markdown
Member Author

baude commented Jul 5, 2019

/test images

@baude baude force-pushed the golandcodeinspect branch from e1dc0ea to beccaa3 Compare July 5, 2019 14:55
@baude
Copy link
Copy Markdown
Member Author

baude commented Jul 5, 2019

@mheon @rhatdan ptal

@baude
Copy link
Copy Markdown
Member Author

baude commented Jul 7, 2019

btw, this should also help reduce the work needed to start using golintci.

giuseppe
giuseppe approved these changes Jul 8, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Jul 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mheon
mheon reviewed Jul 8, 2019
View reviewed changes
Comment thread libpod/container_internal_linux.go Outdated
mheon
mheon reviewed Jul 8, 2019
View reviewed changes
Comment thread libpod/container_internal_linux.go Outdated
mheon
mheon reviewed Jul 8, 2019
View reviewed changes
Comment thread libpod/oci.go Outdated
mheon
mheon reviewed Jul 8, 2019
View reviewed changes
Comment thread libpod/oci_linux.go Outdated
mheon
mheon reviewed Jul 8, 2019
View reviewed changes
Comment thread libpod/runtime_ctr.go Outdated
mheon
mheon reviewed Jul 8, 2019
View reviewed changes
Comment thread libpod/runtime_pod_linux.go Outdated
@baude
code cleanup
1d36501 
clean up code identified as problematic by golands inspection

Signed-off-by: baude <bbaude@redhat.com>
@baude baude force-pushed the golandcodeinspect branch from beccaa3 to 1d36501 Compare July 8, 2019 14:18
@mheon
Copy link
Copy Markdown
Member

mheon commented Jul 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@cevich
Copy link
Copy Markdown
Member

cevich commented Jul 8, 2019

From the small bits I sorta understand, LGTM.

@baude Q: The manager.AllocateLock() calls Do those "lock" the lock for the whole test, or just create one for use? Assuming the first, if the lock releases at the end of tests, isn't this going to make tests run substantially slower (assuming tests are mostly starting containers)?

@mheon
Copy link
Copy Markdown
Member

mheon commented Jul 8, 2019

@cevich It just allocates a lock for use - the actual locking and unlocking is Lock() and Unlock() on the returned lock

@openshift-merge-robot openshift-merge-robot merged commit ed3acae into containers:master Jul 8, 2019
This was referenced Jul 8, 2019
Merged
Merged
Merged
@baude baude deleted the golandcodeinspect branch December 22, 2019 18:52
@nalind nalind mentioned this pull request Sep 7, 2021
Merged
@github-actions github-actions Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mheon mheon mheon left review comments

@giuseppe giuseppe giuseppe approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@mheon mheon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@baude @rh-atomic-bot @openshift-ci-robot @mheon @cevich @giuseppe @openshift-merge-robot