Move logs functionality to separate file for APIv2#6620
Conversation
|
Hi @jgallucci32. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Think you might need to squash your commits down to fix gating, but otherwise LGTM. |
|
LGTM once squished |
|
LGTM |
|
@jgallucci32 Could you remove the merge PR. |
|
@rhatdan I seem to have messed up the jgallucci32/libpod:master branch. In general, what is the best way to pull the latest from base/libpod:master? I thought doing a PR to my forked repo was the best approach, but that didn't seem to go so well. At this point it might be easier to reset and completely redo the branch. Any suggestions? |
|
@jgallucci32 This looks good |
|
/assign @TomSweeneyRedHat |
|
@TomSweeneyRedHat I did a rebase on #6644. Not sure if the extra commit will drop on this PR when merged or if I need to repush, but it is running the checks again. |
|
@jgallucci32 #6644 just went in, you should be able to rebase now and pick it up. |
This simply moves the function for the log handler for APIv2 to a separate file to be consistent with other parts of the code base. Signed-off-by: jgallucci32 <john.gallucci.iv@gmail.com>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgallucci32, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
This simply moves the function for the log handler for
APIv2 to a separate file to be consistent with other parts
of the code base.
Signed-off-by: jgallucci32 john.gallucci.iv@gmail.com