Skip to content

Move logs functionality to separate file for APIv2#6620

Merged
openshift-merge-robot merged 1 commit into
containers:masterfrom
jgallucci32:api-logs-separate
Jun 17, 2020
Merged

Move logs functionality to separate file for APIv2#6620
openshift-merge-robot merged 1 commit into
containers:masterfrom
jgallucci32:api-logs-separate

Conversation

@jgallucci32
Copy link
Copy Markdown
Contributor

This simply moves the function for the log handler for
APIv2 to a separate file to be consistent with other parts
of the code base.

Signed-off-by: jgallucci32 john.gallucci.iv@gmail.com

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

Hi @jgallucci32. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2020
@mheon
Copy link
Copy Markdown
Member

mheon commented Jun 16, 2020

Think you might need to squash your commits down to fix gating, but otherwise LGTM.

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

LGTM once squished

@QiWang19
Copy link
Copy Markdown
Member

LGTM

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jun 16, 2020

@jgallucci32 Could you remove the merge PR.
Something like:

git rebase -i origin
git push --force

@jgallucci32
Copy link
Copy Markdown
Contributor Author

@rhatdan I seem to have messed up the jgallucci32/libpod:master branch. In general, what is the best way to pull the latest from base/libpod:master? I thought doing a PR to my forked repo was the best approach, but that didn't seem to go so well.

At this point it might be easier to reset and completely redo the branch. Any suggestions?

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jun 17, 2020

@jgallucci32 This looks good

@jgallucci32
Copy link
Copy Markdown
Contributor Author

/assign @TomSweeneyRedHat

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

I think this will need a rebase once #6591 is reverted in #6644

@jgallucci32
Copy link
Copy Markdown
Contributor Author

@TomSweeneyRedHat I did a rebase on #6644. Not sure if the extra commit will drop on this PR when merged or if I need to repush, but it is running the checks again.

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

@jgallucci32 #6644 just went in, you should be able to rebase now and pick it up.

This simply moves the function for the log handler for
APIv2 to a separate file to be consistent with other parts
of the code base.

Signed-off-by: jgallucci32 <john.gallucci.iv@gmail.com>
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jun 17, 2020

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2020
@rhatdan rhatdan removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 17, 2020
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jun 17, 2020

/approve

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgallucci32, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2020
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jun 17, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@openshift-merge-robot openshift-merge-robot merged commit a76bf11 into containers:master Jun 17, 2020
@jgallucci32 jgallucci32 deleted the api-logs-separate branch June 22, 2020 17:34
@github-actions github-actions Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants