Revert #6591 to fix issue with failed tests

[jgallucci32]

Signed-off-by: jgallucci32 john.gallucci.iv@gmail.com

[openshift-ci-robot]

Hi @jgallucci32. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[TomSweeneyRedHat]

/ok-to-test

[TomSweeneyRedHat]

LGTM
but I think @mheon had another thought elsewhere and I can't find it quickly.

[jgallucci32]

@TomSweeneyRedHat I did a rebase with the recent #6640 push from @edsantiago to verify his change in log testing still works and it has passed all the checks. This is ready for review.

[jgallucci32]

/assign @umohnani8

[rhatdan]

@jgallucci32 This looks fine to me because it removes functionality, but does the logs --follow code work correctly after this reversal?

Does podman logs -f CTR work if Container is stopped? Paused?

If I am doing podman logs -F CTR and CTR is stopped, does podman logs stop?

LGTM

[jgallucci32]

@rhatdan No, this will reopen issue #6531 which is nessesary as the fix did more harm than good. Once reverted I plan to rebase PR #6614 to properly close the issue and make sure it doesn't reintroduce the check failures.

[TomSweeneyRedHat]

This is all green now and I think will solve a number of CI tests issues once merged.

[rhatdan]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgallucci32, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

Ok Thanks @jgallucci32