Rewrite build tags so they are no longer required #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note this currently incorporates #24 to get tests to pass, so please resolve that ticket first presuming this is a worthwhile patch to you all. :) |
Closed
…ired This rewrites btrfs_noversion to btrfs_version and libdm_no_deferred_remove to libdm_deferred_remove. This allows many systems to compile without build tags; the current situation is that most hosts require the build tags and very few do not. Signed-off-by: Erik Hollensbe <github@hollensbe.org>
erikh
force-pushed
the
rewrite-build-tags
branch
from
dad1802 to
d32f96a
Compare
Contributor
Author
|
rebased |
Member
|
@nalind isn't this what we talked about inverting the build tags? |
Member
Contributor
Author
|
Go ahead and close it.
…On Thu, Oct 4, 2018 at 4:31 AM Valentin Rothberg ***@***.***> wrote:
This issue looks a bit dusty. Is this still an issue or can we close it,
@nalind <https://github.com/nalind>, @rhatdan <https://github.com/rhatdan>,
@erikh <https://github.com/erikh>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABJ6zz6yz8kkVQy6dY5OJj-LukgAiz-ks5uhfGegaJpZM4MNoCA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites btrfs_noversion to btrfs_version and
libdm_no_deferred_remove to libdm_deferred_remove. This allows many
systems to compile without build tags; the current situation is that
most hosts require the build tags and very few do not.
This eliminates the dependency in containers/image and my own project (erikh/box). These tools should be able to
go buildnow without specifying tags and get no compile errors on platforms that have the dependencies installed, even if they are outdated.