Fix lint #27
Closed
Fix lint #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
this also incorporates some other branches, very sorry. this is in no shape for merge yet though. |
erikh
force-pushed
the
fix-lint
branch
2 times, most recently
from
66146f9 to
7fc10e9
Compare
Contributor
Author
added 9 commits
March 6, 2017 11:14
…ired This rewrites btrfs_noversion to btrfs_version and libdm_no_deferred_remove to libdm_deferred_remove. This allows many systems to compile without build tags; the current situation is that most hosts require the build tags and very few do not. Signed-off-by: Erik Hollensbe <github@hollensbe.org>
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
Contributor
Author
|
rebased over #26 |
Member
|
Needs a rebase. |
Member
|
@erikh Can you fix up this pull request? |
Contributor
Author
|
this is goign to take quite a bit of effort. We should probably just close
it.
…On Wed, Apr 19, 2017 at 11:45 AM Daniel J Walsh ***@***.***> wrote:
@erikh <https://github.com/erikh> Can you fix up this pull request?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABJ68okV-s3hFxooP02FeyeudVW55ujks5rxlZZgaJpZM4MN7-D>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes numerous gometalinter (
make lint) related issues by applying fixes and (sometimes large) necessary refactors.This is a WIP and will be finished as I get time, which probably means this week. There is plenty to review already, however, if you are so inclined. Most new changes will end up near the end of the commit list.
PTAL
Fixes #5