Add ZDOTDIR to the list of preserved env vars

[notfirefox]

As discussed here.

• Adds ZDOTDIR to the list of preserved environment variables

Closes #1454

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/71c5d7cc94fb4e6f94688278a6d021f0

✔️ unit-test SUCCESS in 4m 50s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 19s
✔️ unit-test-restricted SUCCESS in 3m 45s
✔️ system-test-fedora-rawhide SUCCESS in 34m 23s
✔️ system-test-fedora-39 SUCCESS in 34m 41s
✔️ system-test-fedora-38 SUCCESS in 35m 56s

[debarshiray]

Thanks for figuring this out, @notfirefox ! Could you please correct your Git authorship information with your full name and a real email address, unless you are worried about privacy?

[notfirefox]

Thanks for figuring this out, @notfirefox ! Could you please correct your Git authorship information with your full name and a real email address, unless you are worried about privacy?

I'd prefer to keep the authorship information as it is because of privacy concerns.

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/1ea0329c9209428a8033d61806065b06

✔️ unit-test SUCCESS in 4m 54s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 43s
✔️ unit-test-restricted SUCCESS in 3m 49s
✔️ system-test-fedora-rawhide SUCCESS in 31m 55s
✔️ system-test-fedora-39 SUCCESS in 33m 26s
✔️ system-test-fedora-38 SUCCESS in 34m 35s

[debarshiray]

Could you please correct your Git authorship information with your full name and a real email address, unless you are worried about privacy?

I'd prefer to keep the authorship information as it is because of privacy concerns.

I see. A few things:

The Signed-off-by trailer has no meaning without a real full name and email address.

I could have made an exception for a one line change, like adding an environment variable, because it would be legally insignificant. However, that's no longer the case with this pull request after the addition of the tests. :)

We need a real full name and email address for tracking copyright holders in case a licensing issue crops up. Note how projects as diverse as GCC, GnuPG, Linux and Podman don't allow anonymous or pseudonymous contributions.

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/7214bd7674e0403f86021ffab5b70fcd

✔️ unit-test SUCCESS in 4m 37s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 39s
✔️ unit-test-restricted SUCCESS in 3m 40s
✔️ system-test-fedora-rawhide SUCCESS in 33m 56s
✔️ system-test-fedora-39 SUCCESS in 35m 05s
✔️ system-test-fedora-38 SUCCESS in 35m 17s

[notfirefox]

@debarshiray DCO related issues should be resolved now.

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/ca0d804049b946c598bad93251c32829

✔️ unit-test SUCCESS in 5m 00s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 42s
✔️ unit-test-restricted SUCCESS in 3m 56s
✔️ system-test-fedora-rawhide SUCCESS in 31m 19s
✔️ system-test-fedora-39 SUCCESS in 33m 37s
✔️ system-test-fedora-38 SUCCESS in 35m 15s

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/4bf7e30f35934ef3b9ef16ea60ec7cb4

✔️ unit-test SUCCESS in 4m 59s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 32s
✔️ unit-test-restricted SUCCESS in 4m 05s
✔️ system-test-fedora-rawhide SUCCESS in 39m 30s
✔️ system-test-fedora-39 SUCCESS in 39m 52s
✔️ system-test-fedora-38 SUCCESS in 40m 16s

[debarshiray]

Thanks for updating the pull request, @notfirefox ! Looks like this needs a rebase against main due to #1460

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/2ffc328da9394d30ba8f154b114bbc53

✔️ unit-test SUCCESS in 5m 30s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 09s
✔️ unit-test-restricted SUCCESS in 4m 07s
✔️ system-test-fedora-rawhide SUCCESS in 34m 25s
✔️ system-test-fedora-39 SUCCESS in 35m 46s
✔️ system-test-fedora-38 SUCCESS in 34m 27s

[notfirefox]

Thanks for updating the pull request, @notfirefox ! Looks like this needs a rebase against main due to #1460

@debarshiray Should be good to go now.