Preserve xterm version#1460
Merged
debarshiray merged 1 commit intocontainers:mainfrom Feb 27, 2024
notfirefox:preserve-xterm-version
Merged
Preserve xterm version#1460debarshiray merged 1 commit intocontainers:mainfrom notfirefox:preserve-xterm-version
debarshiray merged 1 commit intocontainers:mainfrom
notfirefox:preserve-xterm-version
Conversation
|
Build succeeded. ✔️ unit-test SUCCESS in 6m 09s |
XTerm injects its version into the process running inside it through the XTERM_VERSION environment variable [1]. This is used by programs like Neovim to detect the terminal features supported by xterm [2,3,4]. The XTERM_VERSION environment variable is not meant to be set by the shell's start-up scripts, but directly by xterm, and hence needs to be preserved across the host operating system and Toolbx container. [1] https://invisible-island.net/xterm/manpage/xterm.html [2] Neovim commit 3d8e0594e495c42d neovim/neovim@3d8e0594e495c42d [3] Neovim commit 16300d02c7fbe953 neovim/neovim@16300d02c7fbe953 [4] Neovim commit ab7da4c53138768f neovim/neovim@ab7da4c53138768f neovim/neovim#8644 #1449 Signed-off-by: Dominique Polek <dominique.polek@mailbox.org>
debarshiray
reviewed
Feb 27, 2024
Member
debarshiray
left a comment
debarshiray
left a comment
There was a problem hiding this comment.
Wow, that was fast! Thanks, @notfirefox
Member
|
Rebased against I took the liberty to squash the two commits. They are relatively straightforward and there isn't much to say separately about them. |
Member
|
Thank you for your contributions so far, @notfirefox ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here.
XTERM_VERSIONto the list of preserved environment variables