testiso : Support iso-install tests on aarch64#1705
testiso : Support iso-install tests on aarch64#1705openshift-merge-robot merged 1 commit intocoreos:masterfrom
Conversation
| pointerIgnitionPath := "/var/opt/pointer.ign" | ||
|
|
||
| targetDevice := "/dev/vda" | ||
| // For aarch64, the cdrom is a pci blk device /dev/vda |
There was a problem hiding this comment.
Fine for now, note for future: I think we should set things up using the serial= identifer and use /dev/disk/by/id in the future, see also #1343
As a follow up to coreos#1700 also support iso tests on aarch64
Prashanth684
force-pushed
the
iso-aarch64
branch
from
8c038eb to
19d438e
Compare
|
/approve |
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, Prashanth684 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This restores access to the monitor via `Ctrl-A C` and allows passing through `Ctrl-C` to the guest as before. This used to be what QEMU did by default, but when we added an explicit QMP socket in coreos#1705 it disabled that sugar. Closes: coreos#1725
This restores access to the monitor via `Ctrl-A C` and allows passing through `Ctrl-C` to the guest as before. This used to be what QEMU did by default, but when we added an explicit QMP socket in coreos#1705 it disabled that sugar. Closes: coreos#1725
4 participants
As a follow up to #1700 also support iso tests on aarch64