mantle/qemu: explicitly add -serial mon:stdio#1737
mantle/qemu: explicitly add -serial mon:stdio#1737openshift-merge-robot merged 3 commits intocoreos:masterfrom
-serial mon:stdio#1737Conversation
Ahh right OK, this is conflicting with |
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
I was confused by the commit title and description, maybe:
mantle/qemu: Use mon:stdio if not in devshell mode
or something.
That way, the builder will be able to just inspect that field to know if the serial console is being redirected. Prep for next patch.
This restores access to the monitor via `Ctrl-A C` and allows passing through `Ctrl-C` to the guest as before. This used to be what QEMU did by default, but when we added an explicit QMP socket in coreos#1705 it disabled that sugar. Closes: coreos#1725
We want kola to be in control of what happens to the serial console. But `runvm` wants to redirect the console to a file. Add a flag to `qemuexec` to make that possible.
|
OK, reworked this now! |
| cmdQemuExec.Flags().StringArrayVar(&bindrw, "bind-rw", nil, "Same as above, but writable") | ||
| cmdQemuExec.Flags().BoolVarP(&forceConfigInjection, "inject-ignition", "", false, "Force injecting Ignition config using guestfs") | ||
| cmdQemuExec.Flags().BoolVar(&propagateInitramfsFailure, "propagate-initramfs-failure", false, "Error out if the system fails in the initramfs") | ||
| cmdQemuExec.Flags().StringVarP(&consoleFile, "console-to-file", "", "", "Filepath in which to save serial console logs") |
There was a problem hiding this comment.
"Save serial console to this file" maybe? "in which" is better than ending in "in" (which ends in "in" (which...))
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
This restores access to the monitor via
Ctrl-A Cand allows passingthrough
Ctrl-Cto the guest as before.This used to be what QEMU did by default, but when we added an explicit
QMP socket in #1705 it disabled that sugar.
Closes: #1725