Mantle: use Butane libs#2243
Conversation
Signed-off-by: Ben Howard <ben.howard@redhat.com>
|
Did you have a specific reason to switch to vendoring vs forking the binary? (Commit message doesn't say) Currently we don't have dependabot set up on this repo, which is mostly OK but butane is something we will care about and want to keep updated. Right now we have implicit updates when the Fedora package is built. (Also, because not all tooling in this repository is in Go, we need to keep But I'm OK with this too! |
|
👍, APIs >> subprocesses. We can add "update Mantle vendoring" to the Butane release checklist, as we currently have with Ignition. But let's properly integrate this into |
Yes, as a general rule. But I think my point stands that this specific repository is gluing together a lot of different tools in different languages - e.g. we also fork rpm-ostree and parse its JSON, that's unlikely to change. And I definitely run (Anyways not arguing against this either to be clear) |
|
#2246 integrates Butane support into |
|
Superseded by #2246, which is a superior solution. Closing. |
Changes:
qemuexecto use Butane libs over FCCTWhile looking at some tests, I noticed a pattern of:
This change will allow developers the option to use YAML through Butane or write the long JSON.