mantle: support Butane in platform/conf; use that rather than shelling out or hardcoding Ignition#2246
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
I used |
|
Okay, dropped the |
|
/test all |
rather than hardcoding its output. This lets us enable the tests on aarch64 and ppc64le.
|
AFAIK, this is working well for the devshell cases:
Tested using both RHCOS and FCOS. |
|
From my POV, this looks fine -- the Golang looks good (looked it over twice). I'd put my perfunctory stamp, but would rather have @arithx take a look first. |
|
@coreos/multi-arch This PR enables kola tests for boot disk RAID on aarch64 and ppc64le. Please let us know if something is broken. |
| userdata = conf.Ignition(string(v)) | ||
| } else if isreg && (c.Name() == "config.bu" || c.Name() == "config.fcc") { | ||
| b, err := exec.Command("fcct", fpath).Output() | ||
| v, err := ioutil.ReadFile(filepath.Join(dir, c.Name())) |
There was a problem hiding this comment.
It's less exact but technically we could always group the Ignition & Butane/FCCT sections together and use conf.Unknown's detection logic no? Could maybe even loosen it to config* as the qualifier for a config object if we go that route.
There was a problem hiding this comment.
Yeah, I thought about that. Since we already have separate command-line options to distinguish the config types, I'm inclined to keep using those, rather than combining them and expecting the code to guess.
4 participants
Untested.