oscontainer: Push in v2s2 format by default#2726
Merged
jlebon merged 1 commit intocoreos:mainfrom Feb 25, 2022
Merged
Conversation
There was a big quay.io update recently, and the new version supports OCI natively. Which is awesome and will unblock other things such as OCI artifacts. However...it turns out some of the OCP tooling around disconnected installs only works with Docker schema v2s2, not OCI. Let's use v2s2 by default for *this* code which is currently OCP/RHCOS specific. But let's continue to use OCI by default for the new "ostree native container" format push code which lives in `cosa push-container`.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 8, 2022
For similar reasons as coreos#2726 we need to support pushing our containers in v2s2 format, not oci. (Unlike that patch, we don't flip the default though here)
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 15, 2022
For similar reasons as coreos#2726 we need to support pushing our containers in v2s2 format, not oci. (Unlike that patch, we don't flip the default though here)
jlebon
pushed a commit
that referenced
this pull request
Apr 19, 2022
For similar reasons as #2726 we need to support pushing our containers in v2s2 format, not oci. (Unlike that patch, we don't flip the default though here)
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Aug 10, 2022
The cosa image we build is used to trigger internal RHCOS multi-arch
rebuilds (and in the near future will be used directly once we have all
the arches built). But the stack on the target cluster is too old to
understand OCI, so we get:
Internal error occurred: missing signature key
Add `--v2s2` to push in v2s2 format.
Once we've rebased RHCOS to the FCOS pipeline, we should be able to
revert this.
Related: coreos/coreos-assembler#2726
dustymabe
pushed a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
Aug 10, 2022
The cosa image we build is used to trigger internal RHCOS multi-arch
rebuilds (and in the near future will be used directly once we have all
the arches built). But the stack on the target cluster is too old to
understand OCI, so we get:
Internal error occurred: missing signature key
Add `--v2s2` to push in v2s2 format.
Once we've rebased RHCOS to the FCOS pipeline, we should be able to
revert this.
Related: coreos/coreos-assembler#2726
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Oct 31, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: coreos#2726
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Oct 31, 2022
A bunch of tooling around OpenShift don't support the OCI format yet, so for the RHCOS images we need to push in v2s2 format. For FCOS, we want to keep pushing in OCI format. Add a new config.yaml knob to override this for RHCOS. Related: coreos/coreos-assembler#2726
dustymabe
pushed a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Oct 31, 2022
A bunch of tooling around OpenShift don't support the OCI format yet, so for the RHCOS images we need to push in v2s2 format. For FCOS, we want to keep pushing in OCI format. Add a new config.yaml knob to override this for RHCOS. Related: coreos/coreos-assembler#2726
dustymabe
pushed a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
Oct 31, 2022
A bunch of tooling around OpenShift don't support the OCI format yet, so for the RHCOS images we need to push in v2s2 format. For FCOS, we want to keep pushing in OCI format. Add a new config.yaml knob to override this for RHCOS. Related: coreos/coreos-assembler#2726
dustymabe
pushed a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
Oct 31, 2022
A bunch of tooling around OpenShift don't support the OCI format yet, so for the RHCOS images we need to push in v2s2 format. For FCOS, we want to keep pushing in OCI format. Add a new config.yaml knob to override this for RHCOS. Related: coreos/coreos-assembler#2726
dustymabe
pushed a commit
that referenced
this pull request
Oct 31, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: #2726
dustymabe
pushed a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
Oct 31, 2022
A bunch of tooling around OpenShift don't support the OCI format yet, so for the RHCOS images we need to push in v2s2 format. For FCOS, we want to keep pushing in OCI format. Add a new config.yaml knob to override this for RHCOS. Related: coreos/coreos-assembler#2726
dustymabe
pushed a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Nov 1, 2022
A bunch of tooling around OpenShift don't support the OCI format yet, so for the RHCOS images we need to push in v2s2 format. For FCOS, we want to keep pushing in OCI format. Add a new config.yaml knob to override this for RHCOS. Related: coreos/coreos-assembler#2726
dustymabe
pushed a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Nov 1, 2022
A bunch of tooling around OpenShift don't support the OCI format yet, so for the RHCOS images we need to push in v2s2 format. For FCOS, we want to keep pushing in OCI format. Add a new config.yaml knob to override this for RHCOS. Related: coreos/coreos-assembler#2726
dustymabe
pushed a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Nov 1, 2022
A bunch of tooling around OpenShift don't support the OCI format yet, so for the RHCOS images we need to push in v2s2 format. For FCOS, we want to keep pushing in OCI format. Add a new config.yaml knob to override this for RHCOS. Related: coreos/coreos-assembler#2726
dustymabe
pushed a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Nov 1, 2022
A bunch of tooling around OpenShift don't support the OCI format yet, so for the RHCOS images we need to push in v2s2 format. For FCOS, we want to keep pushing in OCI format. Add a new config.yaml knob to override this for RHCOS. Related: coreos/coreos-assembler#2726
dustymabe
pushed a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Nov 3, 2022
A bunch of tooling around OpenShift don't support the OCI format yet, so for the RHCOS images we need to push in v2s2 format. For FCOS, we want to keep pushing in OCI format. Add a new config.yaml knob to override this for RHCOS. Related: coreos/coreos-assembler#2726
dustymabe
pushed a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
Nov 3, 2022
A bunch of tooling around OpenShift don't support the OCI format yet, so for the RHCOS images we need to push in v2s2 format. For FCOS, we want to keep pushing in OCI format. Add a new config.yaml knob to override this for RHCOS. Related: coreos/coreos-assembler#2726
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Nov 7, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: coreos#2726 (cherry picked from commit cd32708)
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Nov 7, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: coreos#2726 (cherry picked from commit cd32708)
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Nov 8, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: coreos#2726 (cherry picked from commit cd32708) (cherry picked from commit 459831c)
jlebon
added a commit
to dustymabe/coreos-assembler
that referenced
this pull request
Nov 10, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: coreos#2726 (cherry picked from commit cd32708) (cherry picked from commit 459831c) (cherry picked from commit 4a2512c)
jlebon
added a commit
to dustymabe/coreos-assembler
that referenced
this pull request
Nov 10, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: coreos#2726 (cherry picked from commit cd32708) (cherry picked from commit 459831c) (cherry picked from commit 4a2512c)
jlebon
added a commit
to dustymabe/coreos-assembler
that referenced
this pull request
Nov 10, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: coreos#2726 (cherry picked from commit cd32708) (cherry picked from commit 459831c) (cherry picked from commit 4a2512c)
dustymabe
pushed a commit
to dustymabe/coreos-assembler
that referenced
this pull request
Nov 10, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: coreos#2726 (cherry picked from commit cd32708) (cherry picked from commit 459831c) (cherry picked from commit 4a2512c)
dustymabe
pushed a commit
to dustymabe/coreos-assembler
that referenced
this pull request
Nov 13, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: coreos#2726 (cherry picked from commit cd32708) (cherry picked from commit 459831c) (cherry picked from commit 4a2512c)
dustymabe
pushed a commit
to dustymabe/coreos-assembler
that referenced
this pull request
Nov 15, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: coreos#2726 (cherry picked from commit cd32708) (cherry picked from commit 459831c) (cherry picked from commit 4a2512c)
dustymabe
pushed a commit
that referenced
this pull request
Nov 15, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: #2726 (cherry picked from commit cd32708) (cherry picked from commit 459831c) (cherry picked from commit 4a2512c)
dustymabe
pushed a commit
to dustymabe/coreos-assembler
that referenced
this pull request
Dec 1, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: coreos#2726 (cherry picked from commit cd32708)
jlebon
added a commit
that referenced
this pull request
Dec 2, 2022
We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless. Related: #2726 (cherry picked from commit cd32708) (cherry picked from commit 459831c) (cherry picked from commit 4a2512c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a big quay.io update recently, and the new version supports
OCI natively. Which is awesome and will unblock other things
such as OCI artifacts.
However...it turns out some of the OCP tooling around disconnected
installs only works with Docker schema v2s2, not OCI.
Let's use v2s2 by default for this code which is currently
OCP/RHCOS specific.
But let's continue to use OCI by default for the new
"ostree native container" format push code which lives in
cosa push-container.