Skip to content

cmd-copy-container: handle v2s2 manifest lists#3151

Merged
dustymabe merged 1 commit intocoreos:mainfrom
jlebon:pr/support-docker-manifest
Oct 31, 2022
Merged

cmd-copy-container: handle v2s2 manifest lists#3151
dustymabe merged 1 commit intocoreos:mainfrom
jlebon:pr/support-docker-manifest

Conversation

@jlebon
Copy link
Copy Markdown
Member

@jlebon jlebon commented Oct 31, 2022

We need to support arch peeling even for multi-arch source containers pushed using v2s2. Thankfully, the schema is identical to the OCI schema for our purposes which makes supporting it painless.

Related: #2726

We need to support arch peeling even for multi-arch source containers
pushed using v2s2. Thankfully, the schema is identical to the OCI schema
for our purposes which makes supporting it painless.

Related: coreos#2726
@dustymabe dustymabe enabled auto-merge (rebase) October 31, 2022 16:20
Copy link
Copy Markdown
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Oct 31, 2022

/override ci/prow/rhcos

Test failure looks unrelated. This isn't tested by Prow.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 31, 2022

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos

Details

In response to this:

/override ci/prow/rhcos

Test failure looks unrelated. This isn't tested by Prow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dustymabe dustymabe merged commit cd32708 into coreos:main Oct 31, 2022
@jlebon jlebon deleted the pr/support-docker-manifest branch April 22, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants