build: Use lockfiles to guard ostree repo and image.json extraction#2892
Merged
jlebon merged 1 commit intocoreos:mainfrom Jun 2, 2022
Merged
build: Use lockfiles to guard ostree repo and image.json extraction#2892jlebon merged 1 commit intocoreos:mainfrom
image.json extraction#2892jlebon merged 1 commit intocoreos:mainfrom
Conversation
CI hit a race where parallel `buildextend-*` would race to generate `tmp/image.json`. We need to lock this for efficiency (avoid duplicate work) and correctness.
1a575b2 to
0c5842a
Compare
jlebon
approved these changes
Jun 2, 2022
Member
Author
|
Looks like some unrelated race in gangplank unit tests, restarted Jenkins run. |
Member
|
gangplank tests are being flaky; restarted again |
miabbott
approved these changes
Jun 2, 2022
This was referenced Jun 2, 2022
Merged
Member
|
hit the issue this is trying to solve in https://jenkins-fedora-coreos-pipeline.apps.ocp.fedoraproject.org/job/build/715/ I think. |
Member
|
I restarted CI on this again to pick up #2895. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI hit a race where parallel
buildextend-*would race to generatetmp/image.json.We need to lock this for efficiency (avoid duplicate work) and
correctness.