build.sh: fix error-handling for make

[jlebon]

We have errexit in build.sh, but that has no effect on make here
because it's part of a command list.

Closes: #2897

[jlebon]

Bash intricacies strike again!

[jlebon]

Here's how I tested this:

diff --git a/build.sh b/build.sh
index 992ead9cd..166f42707 100755
--- a/build.sh
+++ b/build.sh
@@ -101,11 +101,8 @@ install_ocp_tools() {
 }

 make_and_makeinstall() {
-    make
-    make install
-    # Remove go build cache
-    # https://github.com/coreos/coreos-assembler/issues/2872
-    rm -rf /root/.cache/go-build
+    false && make install
+    true
 }

 configure_user(){

$ ./build.sh make_and_makeinstall
++ pwd
+ srcdir=/home/jlebon/Code/gh/c/ca
+ '[' 1 -ne 0 ']'
+ make_and_makeinstall
+ false
+ true
$ echo $?
0

[jlebon]

Hmm OK right, I think the issue is actually that we're not using set -E which makes sure that function calls inherit errexit. Edit: no, -E affects trap inheritance, so I do think it's because of &&. bash(1) says:

-e      Exit immediately if a pipeline (which may consist of a single simple command), a list, or a  compound
        command (see SHELL GRAMMAR above), exits with a non-zero status.  The shell does not exit if the com‐
        mand that fails is part of the command list immediately following a while or until keyword,  part  of
        the test following the if or elif reserved words, part of any command executed in a && or || list ex‐
        cept the command following the final && or ||, any command in a pipeline but the last, or if the com‐
        mand's  return value is being inverted with !.

[dustymabe]

Thanks for looking at this @jlebon!

[dustymabe]

This should also fix #2884

[cgwalters]

Eh, let's just force this in