set COSA_DIR in Dockerfile

[cheesesashimi]

With the introduction of openshift/release#29187, the test stages no longer have an explicitly set COSA_DIR value. Instead, they are calling $ mktemp -d.

[travier]

/lgtm

[miabbott]

/src/ci/prow-build.sh: line 9: cd: /tmp/cosa: No such file or directory

Looks like we need to create it in the prow-build.sh script?

[cheesesashimi]

Looks like we need to create it in the prow-build.sh script?

We can also create it inside the container image. I ran into the same permissions issues I ran into when I was setting up the CI. I fixed it though.

[cheesesashimi]

This is still showing the same failure mode of qemu-img: /var/tmp/mantle-qemu3810394450/disk2048124430: Image creation needs a size parameter. Is it possible that the qemu-img version in the coreos-aseembler image changed and now requires an additional parameter?

EDIT: The kola tests need to be executed from /tmp/cosa, which is presently not the case. The simplest fix is adding a WORKDIR /tmp/cosa to ci/Dockerfile to ensure that all test phases start within that directory.

[cgwalters]

 + cosa buildextend-metal
fatal: /tmp/cosa must be a volume 

yet...we didn't exit out?

Oh no, oh no. coreos/coreos-assembler#2898 strikes again.

[cgwalters]

I pushed two followup commits here, hope that's OK!

[travier]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[travier]

/retest

[openshift-ci]

@cheesesashimi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/test-in-cluster	9de7192	link	true	/test test-in-cluster

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[cgwalters]

OK cool, so it's just the last bit of test-in-cluster which is #829

[cheesesashimi]

I pushed two followup commits here, hope that's OK!

I was about to add ENV COSA_SKIP_OVERLAY=1, but you beat me to it!