Skip to content

Conversation

@MKwenhua
Copy link
Contributor

@MKwenhua MKwenhua commented Mar 3, 2017

Purpose: Since the media title will be replacing id for asset urls most of the "not updating" issues have been resolved. But there was still a risk of someone updating an asset with a different extension meaning posts that use the asset will not update.

I cover this in detail in a Cortex issue: cortex/issues/456

JIRA:
COR-667

Changes:

  • Changes to setup

    • n/a
  • Architectural changes

  • add a validation to check to see if the new asset matches the content_type of the previous asset

  • Migrations

    • n/a
  • Library changes

    • Will probably need to bump up a new version
  • Side effects

    • Assets can no longer be switched from something like an image to an mp4

Screenshots

  • Before
    n/a

  • After
    n/a

QA Links:
n/a

How to Verify These Changes

  • Specific pages to visit

    • n/a
  • Steps to take

    • create a media content type
    • try and create new content type, expect to get an error
  • Responsive considerations

    • n/a

Relevant PRs/Dependencies:
n/a

Additional Information
cortex/issues/456

end
end

def asset_field_type_id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this used for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally before we replaced id's with parameterized Titles updated assets were storing new images on updates since the AssetFieldType id would be different each time. This caused a few issues beyond just storing a new set of images on each update.

But it's purpose is less important now that we use Asset Title instead of ID.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we probably don't need it anymore, since we're using the Media Title. You can go ahead and remove these bits. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sounds good, but this branch wont work on it's own without asset_field_type_id, but it will when merged with the Media Title story

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest merging in the Media Title story, then rebasing this branch with develop. Also, would you mind updating the PR title to follow guidelines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will do

@MKwenhua MKwenhua force-pushed the bugfix/COR-667-Media-Assets-Not-Updating branch from 6a9fad7 to 3a99531 Compare March 10, 2017 18:05
@MKwenhua
Copy link
Contributor Author

@toastercup ok merged with the media title branch and removed asset_field_type_id method

@MKwenhua MKwenhua changed the title Bugfix/cor 667 media assets not updating COR-667: media assets not updating Mar 10, 2017
@MKwenhua MKwenhua changed the title COR-667: media assets not updating COR-667: Media Assets Not Updating Mar 10, 2017
@ElliottAYoung
Copy link
Contributor

@MKwenhua What is the status of this PR? There's been no activity for the last month

@ElliottAYoung
Copy link
Contributor

@toastercup @MKwenhua
With the existence of #57 what should we do with this PR?

@toastercup
Copy link
Member

@ElliottAYoung once #57 is merged and verified by a PO, we can close this and delete its branch

@toastercup toastercup closed this Apr 26, 2017
@toastercup toastercup deleted the bugfix/COR-667-Media-Assets-Not-Updating branch April 26, 2017 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants